Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialog: cleaned up D-Bus portal implementation #12037

Merged
merged 1 commit into from
Jan 21, 2025
Merged

dialog: cleaned up D-Bus portal implementation #12037

merged 1 commit into from
Jan 21, 2025

Conversation

slouken
Copy link
Collaborator

@slouken slouken commented Jan 21, 2025

Fixes #12036

@slouken slouken mentioned this pull request Jan 21, 2025
Closed
@SnootierMoon
Copy link

Thanks for the fast response!

I was about to comment on the fact that path was left uninitialized, but now that's fixed too with the force-push! I tested the new patch and can confirm that the leak is gone.

@slouken
Copy link
Collaborator Author

slouken commented Jan 21, 2025

Thanks for the fast response!

I was about to comment on the fact that path was left uninitialized, but now that's fixed too with the force-push! I tested the new patch and can confirm that the leak is gone.

Great, thanks!

@slouken slouken merged commit 8526868 into libsdl-org:main Jan 21, 2025
41 checks passed
@slouken slouken deleted the update branch January 21, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDL_ShowOpenFileDialog memory leak on Linux
2 participants
@slouken @SnootierMoon